DHBW-WE/MeetUp
5
0
Fork 0
Code Issues 7 Pull requests 5 Projects 1 Releases 5 Packages 1 Wiki Activity Actions

feat: basic login #7

Merged
dominik merged 23 commits from feat/5-basic_login into main 2025-05-08 11:44:28 +00:00
Conversation 2 Commits 23 Files changed 18 +753 -2
lima commented 2025-04-18 19:08:14 +00:00
Member
Copy link

closes #5

closes #5
lima added 9 commits 2025-04-18 19:08:14 +00:00
refactor: remove unused example css code
Some checks failed
container-scan / Container Scan (pull_request) Successful in 1m41s
Details
docker-build / docker (pull_request) Failing after 1m18s
Details
a7e94e9673
fix: docker image build repo name
All checks were successful
container-scan / Container Scan (pull_request) Successful in 1m41s
Details
docker-build / docker (pull_request) Successful in 4m21s
Details
6be739857c
chore: add renovate configuration for dependency management
All checks were successful
container-scan / Container Scan (pull_request) Successful in 1m45s
Details
docker-build / docker (pull_request) Successful in 4m7s
Details
e4a8795b74
style: prettier format
All checks were successful
container-scan / Container Scan (pull_request) Successful in 3m56s
Details
docker-build / docker (pull_request) Successful in 4m33s
Details
47210601f4
dominik force-pushed feat/5-basic_login from 6e153a5de2 to ec359f1eff 2025-04-19 21:34:26 +00:00 Compare
lima added 1 commit 2025-05-04 02:36:15 +00:00
feat: update login and logout components and labels
Some checks failed
container-scan / Container Scan (pull_request) Successful in 5m28s
Details
docker-build / docker (pull_request) Failing after 6m20s
Details
1a34e685bd
lima added 1 commit 2025-05-06 11:37:36 +00:00
feat: trying to add normal login button
Some checks failed
container-scan / Container Scan (pull_request) Failing after 51s
Details
docker-build / docker (pull_request) Failing after 3m50s
Details
cda7900fde
lima added 1 commit 2025-05-06 12:07:53 +00:00
feat: added normal login button
Some checks failed
container-scan / Container Scan (pull_request) Failing after 59s
Details
docker-build / docker (pull_request) Failing after 3m53s
Details
4a4ac04f33
lima changed title from WIP: feat: basic login to feat: basic login 2025-05-06 12:11:06 +00:00
requested review from dominik 2025-05-06 12:11:36 +00:00
dominik requested changes 2025-05-06 12:21:03 +00:00
Dismissed
src/app/login/page.tsx Outdated
@ -0,0 +1,43 @@
// /home/max/Git/MeetUp/src/app/login/page.tsx
dominik commented 2025-05-06 12:12:33 +00:00
Owner
Copy link

Warum ist dieser comment hier drin?

Warum ist dieser comment hier drin?
lima commented 2025-05-06 12:23:04 +00:00
Author
Member
Copy link

Gemini code completion mag das oder so. XD

Gemini code completion mag das oder so. XD
lima marked this conversation as resolved
src/app/login/page.tsx Outdated
@ -0,0 +33,4 @@
/>
</form>
<Login></Login>
dominik commented 2025-05-06 12:15:28 +00:00
Owner
Copy link

Der Login Button sollte mit in das html form element
Am besten alles in ein LoginForm component packen, sonst können wir nicht die action von der form benutzen

Der Login Button sollte mit in das html form element Am besten alles in ein LoginForm component packen, sonst können wir nicht die action von der form benutzen
lima commented 2025-05-06 12:23:20 +00:00
Author
Member
Copy link

Makes Sense

Makes Sense
lima marked this conversation as resolved
src/app/login/page.tsx Outdated
@ -0,0 +37,4 @@
<hr style={{ width: 230 }} />
<SSOLogin provider='authentik' providerDisplayName='SSO' />
dominik commented 2025-05-06 12:16:51 +00:00
Owner
Copy link

Den SSO button sollten wir nur anzeigen, wenn AUTH_AUTHENTIK_ISSUER auch gesetzt ist, dass das ganze dynamisch ist.

{process.env.AUTH_AUTHENTIK_ISSUER && (
  <SSOLogin provider='authentik' providerDisplayName='SSO' /> 
)}
Den SSO button sollten wir nur anzeigen, wenn AUTH_AUTHENTIK_ISSUER auch gesetzt ist, dass das ganze dynamisch ist. ``` {process.env.AUTH_AUTHENTIK_ISSUER && ( <SSOLogin provider='authentik' providerDisplayName='SSO' /> )} ```
dominik marked this conversation as resolved
src/auth.ts Outdated
@ -0,0 +2,4 @@
import Authentik from 'next-auth/providers/authentik';
export const { handlers, signIn, signOut, auth } = NextAuth({
providers: [Authentik],
dominik commented 2025-05-06 12:18:03 +00:00
Owner
Copy link

Der provider sollte auch nur geladen werden, wenn AUTH_AUTHENTIK_ISSUER gesetzt ist.
z.B.

providers: [process.env.AUTH_AUTHENTIK_ISSUER ? Authentik : null].filter(x => x),
Der provider sollte auch nur geladen werden, wenn AUTH_AUTHENTIK_ISSUER gesetzt ist. z.B. ``` providers: [process.env.AUTH_AUTHENTIK_ISSUER ? Authentik : null].filter(x => x), ```
lima commented 2025-05-06 12:33:30 +00:00
Author
Member
Copy link

image

![image](/attachments/1ffdbae4-dbb9-40cc-a2be-343e4915d8d0)
image.png
37 KiB
dominik commented 2025-05-06 12:34:48 +00:00
Owner
Copy link

musst glaub .filter(x => x !== null) machen

musst glaub `.filter(x => x !== null)` machen
dominik marked this conversation as resolved
src/components/button.tsx Outdated
@ -0,0 +14,4 @@
children?: React.ReactNode;
mode?: 'primary' | 'warning' | 'success' | 'danger' | 'neutral';
icon?: IconProp;
width?: number;
dominik commented 2025-05-06 12:20:06 +00:00
Owner
Copy link

Die width von den ganzen komponenten kann man z.B. mit min und max dynamischer machen.

z.B. 14839c0c01

Die width von den ganzen komponenten kann man z.B. mit min und max dynamischer machen. z.B. https://git.dominikstahl.dev/DHBW-WE/MeetUp/commit/14839c0c01fd9b8d4f970c3fbd9819c7c9ae6c60
dominik marked this conversation as resolved
src/components/user/login-button.tsx Outdated
@ -0,0 +1,11 @@
import Button from '../button';
export default function Login({}: {}) {
dominik commented 2025-05-06 12:18:52 +00:00
Owner
Copy link

Die leeren parameter kann man auch weg lassen.

Login() {
Die leeren parameter kann man auch weg lassen. ``` Login() { ```
lima commented 2025-05-06 12:24:19 +00:00
Author
Member
Copy link

Habe ich eigentlich

Habe ich eigentlich
dominik commented 2025-05-06 12:26:36 +00:00
Owner
Copy link

Deswegen ist auch der build fehlgeschlagen (wegen linting)
https://git.dominikstahl.dev/DHBW-WE/MeetUp/actions/runs/183/jobs/0#jobstep-7-340

Deswegen ist auch der build fehlgeschlagen (wegen linting) https://git.dominikstahl.dev/DHBW-WE/MeetUp/actions/runs/183/jobs/0#jobstep-7-340
lima commented 2025-05-06 12:26:44 +00:00
Author
Member
Copy link

Offenbar nicht, LOL

Offenbar nicht, LOL
lima marked this conversation as resolved
lima added 1 commit 2025-05-06 13:09:40 +00:00
fix: disable sso login when no issuer present
Some checks failed
container-scan / Container Scan (pull_request) Failing after 1m1s
Details
docker-build / docker (pull_request) Failing after 3m59s
Details
ba6ab78e14
lima added 2 commits 2025-05-06 13:50:08 +00:00
fix: removes duplicate SSO login component
Some checks failed
container-scan / Container Scan (pull_request) Successful in 1m48s
Details
docker-build / docker (pull_request) Failing after 4m28s
Details
e80cc0246a
dominik added 1 commit 2025-05-07 06:17:25 +00:00
chore: Add recommended vscode extensions to workspace
Some checks failed
container-scan / Container Scan (pull_request) Failing after 46s
Details
docker-build / docker (pull_request) Failing after 4m1s
Details
b1333a84e7 
Add prettier, eslint and conventional commits extension to the workspace recommended extensions
dominik force-pushed feat/5-basic_login from b1333a84e7 to 8d97cd7d65 2025-05-07 06:29:41 +00:00 Compare
lima added 1 commit 2025-05-07 15:34:38 +00:00
feat: add Prisma schema and dependencies for database integration
Some checks failed
container-scan / Container Scan (pull_request) Successful in 4m35s
Details
docker-build / docker (pull_request) Failing after 5m12s
Details
ebc546c409
lima added 1 commit 2025-05-08 10:27:49 +00:00
fix: reorder prisma dependency in package.json
All checks were successful
container-scan / Container Scan (pull_request) Successful in 5m44s
Details
docker-build / docker (pull_request) Successful in 6m9s
Details
bfaa29979a
lima added 1 commit 2025-05-08 10:43:30 +00:00
feat: replace login button with a dedicated login form component
All checks were successful
container-scan / Container Scan (pull_request) Successful in 2m0s
Details
docker-build / docker (pull_request) Successful in 6m19s
Details
0880c70c2e
lima added 1 commit 2025-05-08 11:04:22 +00:00
fix: update middleware to check MEETUP_SKIP_LOGIN environment variable before redirecting to login
All checks were successful
container-scan / Container Scan (pull_request) Successful in 1m57s
Details
docker-build / docker (pull_request) Successful in 5m30s
Details
bf93e5d7f0
lima force-pushed feat/5-basic_login from bf93e5d7f0 to 0187b2e955 2025-05-08 11:14:50 +00:00 Compare
requested review from dominik 2025-05-08 11:15:45 +00:00
lima added 1 commit 2025-05-08 11:17:35 +00:00
fix: remove unnecessary comment from login page
All checks were successful
container-scan / Container Scan (pull_request) Successful in 2m12s
Details
docker-build / docker (pull_request) Successful in 5m43s
Details
6a076c0b93
lima added 1 commit 2025-05-08 11:21:33 +00:00
fix: correct condition for MEETUP_SKIP_LOGIN environment variable in middleware
All checks were successful
container-scan / Container Scan (pull_request) Successful in 2m23s
Details
docker-build / docker (pull_request) Successful in 7m35s
Details
97ea28f588
dominik approved these changes 2025-05-08 11:22:05 +00:00
dominik scheduled this pull request to auto merge when all checks succeed 2025-05-08 11:22:49 +00:00
dominik merged commit 347f845e0c into main 2025-05-08 11:44:28 +00:00
dominik deleted branch feat/5-basic_login 2025-05-08 11:44:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dominik
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Review needed
  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Review needed
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DHBW-WE/MeetUp#7
No description provided.
Delete branch "feat/5-basic_login"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?