DHBW-WE/MeetUp
5
0
Fork 0
Code Issues 7 Pull requests 5 Projects 1 Releases 5 Packages 1 Wiki Activity Actions

refactor: update labels and placeholders in login form inputs #59

Merged
lima merged 2 commits from refactor/58-login_page_labels into main 2025-05-13 21:59:46 +00:00
Conversation 2 Commits 2 Files changed 2 +75 -68
lima commented 2025-05-13 12:07:56 +00:00
Member
Copy link

closes #58

closes #58
lima added 1 commit 2025-05-13 12:07:56 +00:00
fix: update labels and placeholders in login form inputs
Some checks failed
container-scan / Container Scan (pull_request) Failing after 1m10s
Details
docker-build / docker (pull_request) Failing after 4m26s
Details
77a3d11ce0
lima force-pushed refactor/58-login_page_labels from 77a3d11ce0 to 7ce15b655e 2025-05-13 12:08:39 +00:00 Compare
lima force-pushed refactor/58-login_page_labels from 7ce15b655e to 74d7a10cf1 2025-05-13 12:09:49 +00:00 Compare
requested review from dominik 2025-05-13 12:10:04 +00:00
lima changed title from fix: update labels and placeholders in login form inputs to refactor: update labels and placeholders in login form inputs 2025-05-13 12:10:51 +00:00
dominik reviewed 2025-05-13 12:14:08 +00:00
src/components/user/login-form.tsx Outdated
@ -10,1 +9,3 @@
placeholder='Enter your E-Mail'
label='E-Mail or Username'
placeholder='What you are known as.'
name='email'
dominik commented 2025-05-13 12:13:55 +00:00
Owner
Copy link

LabeledInput hat keine name property. Die wird erst in !55 hinzugefügt.

`LabeledInput` hat keine `name` property. Die wird erst in !55 hinzugefügt.
dominik marked this conversation as resolved
dominik added a new dependency 2025-05-13 12:15:02 +00:00
#55 refactor: auth flow, middleware and login page
lima added 1 commit 2025-05-13 12:22:14 +00:00
fix: use name prop for label and input id in LabeledInput component
All checks were successful
container-scan / Container Scan (pull_request) Successful in 1m57s
Details
docker-build / docker (pull_request) Successful in 3m16s
Details
9116dd1085
lima force-pushed refactor/58-login_page_labels from 9116dd1085 to 798467552e 2025-05-13 12:24:59 +00:00 Compare
dominik approved these changes 2025-05-13 18:35:56 +00:00
dominik left a comment
Owner
Copy link

lgtm
nochmal rebasen, dann kannst du mergen.

lgtm nochmal rebasen, dann kannst du mergen.
lima force-pushed refactor/58-login_page_labels from 798467552e to 664d2b6f31 2025-05-13 21:32:33 +00:00 Compare
lima force-pushed refactor/58-login_page_labels from 664d2b6f31 to 10bc17eba5 2025-05-13 21:44:00 +00:00 Compare
lima force-pushed refactor/58-login_page_labels from 10bc17eba5 to aebf89a83e 2025-05-13 21:53:10 +00:00 Compare
lima merged commit bc59e78bd5 into main 2025-05-13 21:59:46 +00:00
lima deleted branch refactor/58-login_page_labels 2025-05-13 21:59:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dominik
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Review needed
  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Review needed
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#55 refactor: auth flow, middleware and login page
DHBW-WE/MeetUp
Reference: DHBW-WE/MeetUp#59
No description provided.
Delete branch "refactor/58-login_page_labels"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?