From 5f8fc199a4f72a2eace616c13a6e620a823adb1a Mon Sep 17 00:00:00 2001 From: Andreas Schildbach Date: Wed, 4 Feb 2015 17:44:53 +0100 Subject: [PATCH] Change return type of Trip.products() from List to Set. --- enabler/src/de/schildbach/pte/dto/Trip.java | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/enabler/src/de/schildbach/pte/dto/Trip.java b/enabler/src/de/schildbach/pte/dto/Trip.java index 32e6f2ec..6a266ddb 100644 --- a/enabler/src/de/schildbach/pte/dto/Trip.java +++ b/enabler/src/de/schildbach/pte/dto/Trip.java @@ -19,9 +19,10 @@ package de.schildbach.pte.dto; import java.io.Serializable; import java.util.Date; -import java.util.LinkedList; +import java.util.EnumSet; import java.util.List; import java.util.Locale; +import java.util.Set; import com.google.common.base.MoreObjects; import com.google.common.base.MoreObjects.ToStringHelper; @@ -186,22 +187,14 @@ public final class Trip implements Serializable return true; } - public List products() + public Set products() { - final List products = new LinkedList(); + final Set products = EnumSet.noneOf(Product.class); if (legs != null) - { for (final Leg leg : legs) - { if (leg instanceof Public) - { - final Product product = Product.fromCode(((Public) leg).line.label.charAt(0)); - if (!products.contains(product)) - products.add(product); - } - } - } + products.add(Product.fromCode(((Public) leg).line.label.charAt(0))); return products; }