mirrors/oeffi
1
0
Fork 0
mirror of https://gitlab.com/oeffi/oeffi.git synced 2025-07-08 10:08:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

StationContextMenu: Fix NullPointerException in prepareMapMenu().

Browse source
This commit is contained in:
Andreas Schildbach 2018-11-26 17:29:43 +01:00
parent f09ec8fb60
commit a4fba695a4
1 changed files with 55 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

123
oeffi/src/de/schildbach/oeffi/stations/StationContextMenu.java
View file

@ -125,80 +125,56 @@ public class StationContextMenu extends PopupMenu {
public static void prepareMapMenu(final Context context, final Menu menu, final NetworkId network, public static void prepareMapMenu(final Context context, final Menu menu, final NetworkId network,
final Location location) { final Location location) {
final PackageManager pm = context.getPackageManager();
new MenuInflater(context).inflate(R.menu.station_map_context, menu); new MenuInflater(context).inflate(R.menu.station_map_context, menu);
final double lat = location.getLatAsDouble();
final double lon = location.getLonAsDouble();
final String name = location.name;
final MenuItem googleMapsItem = menu.findItem(R.id.station_map_context_google_maps); final MenuItem googleMapsItem = menu.findItem(R.id.station_map_context_google_maps);
final Intent googleMapsIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "geo:%.6f,%.6f?q=%.6f,%.6f%s", lat, lon, lat, lon,
name != null ? '(' + URLEncoder.encode(name.replaceAll("[()]", "")) + ')' : "")));
googleMapsIntent.setComponent(
new ComponentName("com.google.android.apps.maps", "com.google.android.maps.MapsActivity"));
googleMapsItem.setVisible(location.hasCoord() && pm.resolveActivity(googleMapsIntent, 0) != null);
googleMapsItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
public boolean onMenuItemClick(final MenuItem item) {
context.startActivity(googleMapsIntent);
return true;
}
});
final MenuItem amazonMapsItem = menu.findItem(R.id.station_map_context_amazon_maps); final MenuItem amazonMapsItem = menu.findItem(R.id.station_map_context_amazon_maps);
final Intent amazonMapsIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "geo:%.6f,%.6f?q=%.6f,%.6f%s", lat, lon, lat, lon,
name != null ? '(' + URLEncoder.encode(name.replaceAll("[()]", "")) + ')' : "")));
amazonMapsIntent.setComponent(
new ComponentName("com.amazon.geo.client.maps", "com.amazon.geo.client.renderer.MapsAppActivityDuke"));
amazonMapsItem.setVisible(location.hasCoord() && pm.resolveActivity(amazonMapsIntent, 0) != null);
amazonMapsItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
public boolean onMenuItemClick(final MenuItem item) {
context.startActivity(amazonMapsIntent);
return true;
}
});
final MenuItem openStreetMapsItem = menu.findItem(R.id.station_map_context_open_street_maps); final MenuItem openStreetMapsItem = menu.findItem(R.id.station_map_context_open_street_maps);
final Intent openStreetMapsIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "osmand.geo:%.6f,%.6f?q=%.6f,%.6f%s", lat, lon, lat, lon,
name != null ? '(' + URLEncoder.encode(name.replaceAll("[()]", "")) + ')' : "")));
openStreetMapsItem.setVisible(location.hasCoord() && pm.resolveActivity(openStreetMapsIntent, 0) != null);
openStreetMapsItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
public boolean onMenuItemClick(final MenuItem item) {
context.startActivity(openStreetMapsIntent);
return true;
}
});
final MenuItem googleStreetViewItem = menu.findItem(R.id.station_map_context_google_street_view); final MenuItem googleStreetViewItem = menu.findItem(R.id.station_map_context_google_street_view);
final Intent googleStreetViewIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "google.streetview:cbll=%.6f,%.6f", lat, lon)));
googleStreetViewIntent
.setComponent(new ComponentName("com.google.android.street", "com.google.android.street.Street"));
googleStreetViewItem.setVisible(location.hasCoord() && pm.resolveActivity(googleStreetViewIntent, 0) != null);
googleStreetViewItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
public boolean onMenuItemClick(final MenuItem item) {
context.startActivity(googleStreetViewIntent);
return true;
}
});
final MenuItem googleNavigationItem = menu.findItem(R.id.station_map_context_google_navigation); final MenuItem googleNavigationItem = menu.findItem(R.id.station_map_context_google_navigation);
final Intent googleNavigationIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "google.navigation:ll=%.6f,%.6f&title=%s&mode=w", lat, lon, if (location.hasCoord()) {
name != null ? URLEncoder.encode(name) : ""))); final double lat = location.getLatAsDouble();
googleNavigationIntent.setComponent(new ComponentName("com.google.android.apps.maps", final double lon = location.getLonAsDouble();
"com.google.android.maps.driveabout.app.NavigationActivity")); final String name = location.name;
googleNavigationItem.setVisible(location.hasCoord() && pm.resolveActivity(googleNavigationIntent, 0) != null);
googleNavigationItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() { final Intent googleMapsIntent = new Intent(Intent.ACTION_VIEW,
public boolean onMenuItemClick(final MenuItem item) { Uri.parse(String.format(Locale.ENGLISH, "geo:%.6f,%.6f?q=%.6f,%.6f%s", lat, lon, lat, lon,
context.startActivity(googleNavigationIntent); name != null ? '(' + URLEncoder.encode(name.replaceAll("[()]", "")) + ')' : "")));
return true; googleMapsIntent.setComponent(
} new ComponentName("com.google.android.apps.maps", "com.google.android.maps.MapsActivity"));
}); prepareMapMenuItem(context, googleMapsItem, googleMapsIntent);
final Intent amazonMapsIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "geo:%.6f,%.6f?q=%.6f,%.6f%s", lat, lon, lat, lon,
name != null ? '(' + URLEncoder.encode(name.replaceAll("[()]", "")) + ')' : "")));
amazonMapsIntent.setComponent(new ComponentName("com.amazon.geo.client.maps",
"com.amazon.geo.client.renderer.MapsAppActivityDuke"));
prepareMapMenuItem(context, amazonMapsItem, amazonMapsIntent);
final Intent openStreetMapsIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "osmand.geo:%.6f,%.6f?q=%.6f,%.6f%s", lat, lon, lat, lon,
name != null ? '(' + URLEncoder.encode(name.replaceAll("[()]", "")) + ')' : "")));
prepareMapMenuItem(context, openStreetMapsItem, openStreetMapsIntent);
final Intent googleStreetViewIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "google.streetview:cbll=%.6f,%.6f", lat, lon)));
googleStreetViewIntent
.setComponent(new ComponentName("com.google.android.street", "com.google.android.street.Street"));
prepareMapMenuItem(context, googleStreetViewItem, googleStreetViewIntent);
final Intent googleNavigationIntent = new Intent(Intent.ACTION_VIEW,
Uri.parse(String.format(Locale.ENGLISH, "google.navigation:ll=%.6f,%.6f&title=%s&mode=w", lat, lon,
name != null ? URLEncoder.encode(name) : "")));
googleNavigationIntent.setComponent(new ComponentName("com.google.android.apps.maps",
"com.google.android.maps.driveabout.app.NavigationActivity"));
prepareMapMenuItem(context, googleNavigationItem, googleNavigationIntent);
} else {
googleMapsItem.setVisible(false);
amazonMapsItem.setVisible(false);
openStreetMapsItem.setVisible(false);
googleStreetViewItem.setVisible(false);
googleNavigationItem.setVisible(false);
}
final ContentResolver contentResolver = context.getContentResolver(); final ContentResolver contentResolver = context.getContentResolver();
final Cursor stationsCursor = contentResolver.query(PlanContentProvider.stationsUri(network, location.id), null, final Cursor stationsCursor = contentResolver.query(PlanContentProvider.stationsUri(network, location.id), null,
@ -223,4 +199,15 @@ public class StationContextMenu extends PopupMenu {
stationsCursor.close(); stationsCursor.close();
} }
} }
private static void prepareMapMenuItem(final Context context, final MenuItem item, final Intent intent) {
final PackageManager pm = context.getPackageManager();
item.setVisible(pm.resolveActivity(intent, 0) != null);
item.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
public boolean onMenuItemClick(final MenuItem item) {
context.startActivity(intent);
return true;
}
});
}
} }