DHBW-WE/MeetUp
5
0
Fork 0
Code Issues 7 Pull requests 5 Projects 1 Releases 5 Packages 1 Wiki Activity Actions

feat: add favicon.ico #79

Merged
micha.bok merged 9 commits from feat/78-add_favicon_ico into main 2025-05-22 14:05:33 +00:00
Conversation 5 Commits 9 Files changed 11 +77 -1
micha.bok commented 2025-05-22 11:21:14 +00:00
Member
Copy link

closes #78

closes #78
micha.bok added 2 commits 2025-05-22 11:21:14 +00:00
fix: format previous commit
All checks were successful
container-scan / Container Scan (pull_request) Successful in 3m0s
Details
docker-build / docker (pull_request) Successful in 4m34s
Details
c2a074f734
requested review from dominik 2025-05-22 11:29:17 +00:00
dominik changed title from feat/78-add_favicon_ico to feature: add favicon.ico 2025-05-22 11:30:07 +00:00
dominik reviewed 2025-05-22 11:31:29 +00:00
src/app/layout.tsx Outdated
@ -18,0 +39,4 @@
rel='apple-touch-icon'
sizes='180x180'
href='/apple-touch-icon.png'
/>
dominik commented 2025-05-22 11:31:29 +00:00
Owner
Copy link

Ist jetzt aber nur an das browser theme angepasst, wenn die svg version verwendet wird.

Ist jetzt aber nur an das browser theme angepasst, wenn die svg version verwendet wird.
micha.bok commented 2025-05-22 11:34:16 +00:00
Author
Member
Copy link

Stimmt.
Aber wann wird das nicht verwendet?

Stimmt. Aber wann wird das nicht verwendet?
dominik commented 2025-05-22 11:35:19 +00:00
Owner
Copy link

Wenn der Browser das z.B. nicht unterstützt (siehe hier)

PNGs werden da besser unterstützt.

Wenn der Browser das z.B. nicht unterstützt [(siehe hier)](https://caniuse.com/link-icon-svg) [PNGs](https://caniuse.com/link-icon-png) werden da besser unterstützt.
dominik marked this conversation as resolved
micha.bok added 1 commit 2025-05-22 12:38:38 +00:00
feat: add .png icons for safari
All checks were successful
container-scan / Container Scan (pull_request) Successful in 2m51s
Details
docker-build / docker (pull_request) Successful in 4m26s
Details
08a83ba3c5
dominik changed title from feature: add favicon.ico to feat: add favicon.ico 2025-05-22 12:48:12 +00:00
dominik reviewed 2025-05-22 12:50:57 +00:00
dominik left a comment
Owner
Copy link

nimmst du die favicon-96x96.png noch raus, glaub die wird nicht verwendet. Sonst passt das.

nimmst du die favicon-96x96.png noch raus, glaub die wird nicht verwendet. Sonst passt das.
micha.bok commented 2025-05-22 12:56:19 +00:00
Author
Member
Copy link

@dominik wrote in #79 (comment):

nimmst du die favicon-96x96.png noch raus, glaub die wird nicht verwendet. Sonst passt das.

ja vergessen, danke für den Hinweis :)

@dominik wrote in https://git.dominikstahl.dev/DHBW-WE/MeetUp/pulls/79#issuecomment-737: > nimmst du die favicon-96x96.png noch raus, glaub die wird nicht verwendet. Sonst passt das. ja vergessen, danke für den Hinweis :)
micha.bok added 1 commit 2025-05-22 12:59:18 +00:00
fix: remove unused favicon image
All checks were successful
container-scan / Container Scan (pull_request) Successful in 2m58s
Details
docker-build / docker (pull_request) Successful in 4m14s
Details
784549f7e1
dominik approved these changes 2025-05-22 13:03:16 +00:00
micha.bok added 1 commit 2025-05-22 13:13:57 +00:00
refactor: simplify middleware
All checks were successful
container-scan / Container Scan (pull_request) Successful in 2m47s
Details
docker-build / docker (pull_request) Successful in 4m33s
Details
5bcb16a9b5
dominik reviewed 2025-05-22 13:20:52 +00:00
src/middleware.ts Outdated
@ -3,2 +3,3 @@
export const config = {
matcher: ['/((?!api|_next/static|_next/image|favicon.ico).*)'],
matcher: [
'/((?!api|_next/static|_next/image|site.webmanifest|web-app-manifest-192x192.png|web-app-manifest-512x512.png|favicon-(?:dark|light)?\.(?:png|svg)).*)',
dominik commented 2025-05-22 13:20:52 +00:00
Owner
Copy link

kannst das noch etwas weiter zusammen fassen.

web-app-manifest-192x192.png|web-app-manifest-512x512.png
zu
web-app-manifest- (also alle pfade die mit web-app-manifest- beginnen

kannst das noch etwas weiter zusammen fassen. `web-app-manifest-192x192.png|web-app-manifest-512x512.png` zu `web-app-manifest-` (also alle pfade die mit web-app-manifest- beginnen
dominik marked this conversation as resolved
micha.bok added 1 commit 2025-05-22 13:25:53 +00:00
fix: update matcher regex for web app manifest and favicon
Some checks failed
container-scan / Container Scan (pull_request) Failing after 31s
Details
docker-build / docker (pull_request) Failing after 3m11s
Details
76f75f0b57
micha.bok added 1 commit 2025-05-22 13:27:52 +00:00
fix: add newline at end of middleware.ts file
Some checks failed
container-scan / Container Scan (pull_request) Failing after 34s
Details
docker-build / docker (pull_request) Failing after 3m22s
Details
89b73865ec
micha.bok added 1 commit 2025-05-22 13:45:18 +00:00
fix: correct regex pattern for matcher in middleware
Some checks failed
container-scan / Container Scan (pull_request) Failing after 18s
Details
docker-build / docker (pull_request) Failing after 3m19s
Details
df7413d6ba
micha.bok added 1 commit 2025-05-22 13:53:21 +00:00
style: yarn format fix komma issue
All checks were successful
container-scan / Container Scan (pull_request) Successful in 2m37s
Details
docker-build / docker (pull_request) Successful in 4m2s
Details
e298aec60e
micha.bok merged commit 226c257b6f into main 2025-05-22 14:05:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dominik
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Review needed
  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Review needed
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DHBW-WE/MeetUp#79
No description provided.
Delete branch "feat/78-add_favicon_ico"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?