DHBW-WE/MeetUp
5
0
Fork 0
Code Issues 7 Pull requests 5 Projects 1 Releases 5 Packages 1 Wiki Activity Actions

feat: add theme toggle #48

Merged
lima merged 4 commits from feat/45-add_theme_toggle into main 2025-05-12 08:55:25 +00:00
Conversation 6 Commits 4 Files changed 6 +602 -16
lima commented 2025-05-11 11:48:30 +00:00
Member
Copy link
No description provided.
lima added 4 commits 2025-05-11 11:48:30 +00:00
feat: restructure Home component layout and add ThemePicker
Some checks failed
container-scan / Container Scan (pull_request) Failing after 1m15s
Details
docker-build / docker (pull_request) Failing after 7m35s
Details
aea691dec4
requested review from Contributor 2025-05-11 11:49:14 +00:00
lima commented 2025-05-11 11:50:33 +00:00
Author
Member
Copy link

closes #45

closes #45
lima added 1 commit 2025-05-11 12:01:04 +00:00
fix: standardize quotes and formatting in DropdownMenu component
All checks were successful
container-scan / Container Scan (pull_request) Successful in 1m20s
Details
docker-build / docker (pull_request) Successful in 9m44s
Details
6fcc9076f4
dominik commented 2025-05-11 17:33:12 +00:00
Owner
Copy link

für code style changes wie in 6fcc9076f4 ist als commit message eigentlich style: <message> gedacht. Kannst du das mit nem interactive rebase ändern?

für code style changes wie in https://git.dominikstahl.dev/DHBW-WE/MeetUp/commit/6fcc9076f44dd5364fcf9bdc9116579794a7254d ist als commit message eigentlich `style: <message>` gedacht. Kannst du das mit nem interactive rebase ändern?
lima commented 2025-05-11 17:38:10 +00:00
Author
Member
Copy link

mach ich

mach ich
lima force-pushed feat/45-add_theme_toggle from 6fcc9076f4 to b513636ff5 2025-05-11 17:51:18 +00:00 Compare
lima force-pushed feat/45-add_theme_toggle from b513636ff5 to 749a24a44d 2025-05-12 08:02:41 +00:00 Compare
dominik requested changes 2025-05-12 08:20:18 +00:00
Dismissed
dominik left a comment
Owner
Copy link

würde den theme picker in die layout.tsx mit position: sticky packen. dann ist das automatisch auf allen seiten.

würde den theme picker in die layout.tsx mit position: sticky packen. dann ist das automatisch auf allen seiten.
lima commented 2025-05-12 08:31:12 +00:00
Author
Member
Copy link

@dominik wrote in #48 (comment):

würde den theme picker in die layout.tsx mit position: sticky packen. dann ist das automatisch auf allen seiten.

im login ist der damit man das umstellen kann bevor man sich einloggt da die einstellung sonst in den settings landet und der ist nur temporär auf /home da noch nichts von design ausgemacht wurde

@dominik wrote in https://git.dominikstahl.dev/DHBW-WE/MeetUp/pulls/48#issuecomment-468: > würde den theme picker in die layout.tsx mit position: sticky packen. dann ist das automatisch auf allen seiten. im login ist der damit man das umstellen kann bevor man sich einloggt da die einstellung sonst in den settings landet und der ist nur temporär auf /home da noch nichts von design ausgemacht wurde
👍 1
dominik approved these changes 2025-05-12 08:38:33 +00:00
lima merged commit 8ef6478ea4 into main 2025-05-12 08:55:25 +00:00
lima deleted branch feat/45-add_theme_toggle 2025-05-12 08:55:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dominik
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Review needed
  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Review needed
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DHBW-WE/MeetUp#48
No description provided.
Delete branch "feat/45-add_theme_toggle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?